linux-kernel - Re: [PATCH 1/1] ASoC: codec: wm8960: add additional probe check for codec identification

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230717095254.GA103419@ediswmail.ad.cirrus.com>
Date:   Mon, 17 Jul 2023 09:52:54 +0000
From:   Charles Keepax <ckeepax@...nsource.cirrus.com>
To:     Frank Li <Frank.Li@....com>
CC:     Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>,
        Vladimir Oltean <olteanv@...il.com>,
        Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>,
        Krzysztof Hałasa <khalasa@...p.pl>,
        Wolfram Sang <wsa@...nel.org>,
        Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
        "open list:WOLFSON MICROELECTRONICS DRIVERS" 
        <patches@...nsource.cirrus.com>,
        "moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM..." 
        <alsa-devel@...a-project.org>,
        open list <linux-kernel@...r.kernel.org>,
        <imx@...ts.linux.dev>, <shengjiu.wang@....com>
Subject: Re: [PATCH 1/1] ASoC: codec: wm8960: add additional probe check for
 codec identification

On Thu, Jul 13, 2023 at 06:25:12PM -0400, Frank Li wrote:
> The wm8960 codec is not readable, resulting in a NACK for address 0x3d (8-bit).
> This can partially indicate it. For example: wm8962 codec use the same address
> but is readable. This additional probe check will help prevent loading the wm8960
> module incorrectly on wm8962 hardware.
> 
> Signed-off-by: Frank Li <Frank.Li@....com>
> ---

Seems reasonable to me:

Acked-by: Charles Keepax <ckeepax@...nsource.cirrus.com>

Thanks,
Charles