linux-kernel - Re: [PATCH V1 0/5] ASoC: codecs: Add Awinic AW88261 audio amplifier driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230717145456.5afee0cf@bootlin.com>
Date:   Mon, 17 Jul 2023 15:03:51 +0200
From:   Herve Codina <herve.codina@...tlin.com>
To:     unlisted-recipients:; (no To-header on input)
Cc:     shumingf@...ltek.com, flatmax@...tmax.com,
        ckeepax@...nsource.cirrus.com, doug@...morgal.com,
        fido_max@...ox.ru, pierre-louis.bossart@...ux.intel.com,
        kiseok.jo@...ndevice.com, liweilei@...nic.com,
        colin.i.king@...il.com, trix@...hat.com,
        alsa-devel@...a-project.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, yijiangtao@...nic.com,
        zhangjianming@...nic.com
Subject: Re: [PATCH V1 0/5]  ASoC: codecs: Add Awinic AW88261 audio
 amplifier driver

Hi Weidong,

On Mon, 17 Jul 2023 19:58:40 +0800
wangweidong.a@...nic.com wrote:

> From: Weidong Wang <wangweidong.a@...nic.com>
> 
> The AW88261 is an I2S/TDM input, high efficiency
> digital Smart K audio amplifier with an integrated 10.25V
> smart boost convert
> 
> Add a DT schema for describing Awinic aw88261 audio amplifiers. They are
> controlled using I2C.
> 
> Weidong Wang (5):
>   ASoC: codecs: Add i2c and codec registration for aw88261 and their
>     associated operation functions
>   ASoC: codecs: aw88261 function for ALSA Audio Driver
>   ASoC: codecs: ACF bin parsing and check library file for aw88261
>   ASoC: codecs: aw88261 chip register file, data type file and Kconfig
>     Makefile
>   ASoC: dt-bindings: Add schema for "awinic,aw88261"
> 
>  .../bindings/sound/awinic,aw88261.yaml        |  53 +
>  sound/soc/codecs/Kconfig                      |  17 +
>  sound/soc/codecs/Makefile                     |   5 +
>  sound/soc/codecs/aw88261/aw88261.c            | 539 ++++++++++
>  sound/soc/codecs/aw88261/aw88261.h            |  52 +
>  sound/soc/codecs/aw88261/aw88261_data_type.h  | 144 +++
>  sound/soc/codecs/aw88261/aw88261_device.c     | 959 +++++++++++++++++
>  sound/soc/codecs/aw88261/aw88261_device.h     | 114 ++
>  sound/soc/codecs/aw88261/aw88261_lib.c        | 997 ++++++++++++++++++
>  sound/soc/codecs/aw88261/aw88261_lib.h        |  91 ++
>  sound/soc/codecs/aw88261/aw88261_reg.h        | 377 +++++++
>  11 files changed, 3348 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/sound/awinic,aw88261.yaml
>  create mode 100644 sound/soc/codecs/aw88261/aw88261.c
>  create mode 100644 sound/soc/codecs/aw88261/aw88261.h
>  create mode 100644 sound/soc/codecs/aw88261/aw88261_data_type.h
>  create mode 100644 sound/soc/codecs/aw88261/aw88261_device.c
>  create mode 100644 sound/soc/codecs/aw88261/aw88261_device.h
>  create mode 100644 sound/soc/codecs/aw88261/aw88261_lib.c
>  create mode 100644 sound/soc/codecs/aw88261/aw88261_lib.h
>  create mode 100644 sound/soc/codecs/aw88261/aw88261_reg.h
> 
> 
> base-commit: 8d7868c41df58edabc4e408d119a1aef58a54d9d

A lot of code looks pretty similar (the same ?) to what was done for aw88395
  sound/soc/codecs/aw88395/

Is there a way to use common code instead of duplication ?

Best regards,
Hervé Codina