linux-kernel - Re: [PATCH v2] interconnect: qcom: icc-rpm: Explicitly return 0 at the end of the function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 17 Jul 2023 15:04:00 +0200
From:   Stephan Gerhold <stephan@...hold.net>
To:     djakov@...nel.org
Cc:     konrad.dybcio@...aro.org, andersson@...nel.org,
        linux-arm-msm@...r.kernel.org, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] interconnect: qcom: icc-rpm: Explicitly return 0 at
 the end of the function

On Mon, Jul 17, 2023 at 03:55:34PM +0300, djakov@...nel.org wrote:
> From: Georgi Djakov <djakov@...nel.org>
> 
> Fix the following smatch error:
> drivers/interconnect/qcom/icc-rpm.c:243 qcom_icc_rpm_set() error: uninitialized symbol 'ret'.
> 
> Fixes: 32846c4a8f2a ("interconnect: qcom: icc-rpm: Set bandwidth on both contexts")
> Signed-off-by: Georgi Djakov <djakov@...nel.org>
> ---
> v2: Just return 0 when reaching the end of the function. (Thanks Stephan!)
> v1: https://lore.kernel.org/r/20230717073429.2115015-1-djakov@kernel.org
> 
>  drivers/interconnect/qcom/icc-rpm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/interconnect/qcom/icc-rpm.c b/drivers/interconnect/qcom/icc-rpm.c
> index 612390b9eb18..2c16917ba1fd 100644
> --- a/drivers/interconnect/qcom/icc-rpm.c
> +++ b/drivers/interconnect/qcom/icc-rpm.c
> @@ -240,7 +240,7 @@ static int qcom_icc_rpm_set(struct qcom_icc_node *qn, u64 *bw)
>  		}
>  	}
>  
> -	return ret;
> +	return 0;
>  }
>  
>  /**

Thanks!

Reviewed-by: Stephan Gerhold <stephan@...hold.net>