[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZLafZGjjS0xSGWX5@smile.fi.intel.com>
Date: Tue, 18 Jul 2023 17:19:16 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Harshit Mogalapalli <harshit.m.mogalapalli@...cle.com>
Cc: Tomi Valkeinen <tomi.valkeinen@...asonboard.com>,
Mauro Carvalho Chehab <mchehab@...nel.org>,
Sakari Ailus <sakari.ailus@...ux.intel.com>,
linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
dan.carpenter@...aro.org, kernel-janitors@...r.kernel.org,
error27@...il.com
Subject: Re: [PATCH v2 next] media: i2c: fix error handling in
ub960_rxport_add_serializer()
On Tue, Jul 18, 2023 at 07:06:58AM -0700, Harshit Mogalapalli wrote:
> Smatch warns:
> drivers/media/i2c/ds90ub960.c:1671 ub960_rxport_add_serializer():
> err: 'rxport->ser.client' dereferencing possible ERR_PTR()
>
> i2c_new_client_device() returns error pointers on failure and in
> dev_dbg statement we are dereferencing error pointer which is a bug.
>
> Fix this by using IS_ERR() which checks for error pointers.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
--
With Best Regards,
Andy Shevchenko
Powered by blists - more mailing lists