linux-kernel - RE: [PATCH v2] pwm: fix pwm-rz-mtu3.c build errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <TYWPR01MB877573685497B68FFB2590BBC238A@TYWPR01MB8775.jpnprd01.prod.outlook.com>
Date:   Tue, 18 Jul 2023 15:07:35 +0000
From:   Fabrizio Castro <fabrizio.castro.jz@...esas.com>
To:     Randy Dunlap <rd.dunlab@...il.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-pwm@...r.kernel.org" <linux-pwm@...r.kernel.org>
CC:     Biju Das <biju.das.jz@...renesas.com>,
        Thierry Reding <thierry.reding@...il.com>,
        Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>
Subject: RE: [PATCH v2] pwm: fix pwm-rz-mtu3.c build errors

Hi Randy,

> From: Randy Dunlap <rd.dunlab@...il.com>
> Subject: Re: [PATCH v2] pwm: fix pwm-rz-mtu3.c build errors
> 
> On 7/18/23 05:13, Fabrizio Castro wrote:
> > Hi Randy,
> >
> >> From: Randy Dunlap <rd.dunlab@...il.com>
> >> Subject: [PATCH v2] pwm: fix pwm-rz-mtu3.c build errors
> >>
> >> From: Randy Dunlap <rd.dunlab@...il.com>
> >>
> >> When (MFD) RZ_MTU3=m and PWM_RZ_MTU3=y, there are numerous build
> >> errors:
> >>
> >>
> >> Modify the dependencies of PWM_RZ_MTU3 so that COMPILE_TEST is
> >> still allowed but PWM_RZ_MTU3 depends on RZ_MTU3 if it is being
> built
> >> but also allow the latter not to be built.
> >>
> >>  drivers/pwm/Kconfig |    3 ++-
> >>  1 file changed, 2 insertions(+), 1 deletion(-)
> >>
> >> diff -- a/drivers/pwm/Kconfig b/drivers/pwm/Kconfig
> >> --- a/drivers/pwm/Kconfig
> >> +++ b/drivers/pwm/Kconfig
> >> @@ -505,7 +505,8 @@ config PWM_ROCKCHIP
> >>
> >>  config PWM_RZ_MTU3
> >>  	tristate "Renesas RZ/G2L MTU3a PWM Timer support"
> >> -	depends on RZ_MTU3 || COMPILE_TEST
> >> +	depends on COMPILE_TEST
> >> +	depends on RZ_MTU3 || RZ_MTU3=n
> >
> > Isn't this a tautology?
> 
> Not at all. It's used in Kconfig quite a bit.
> This is tristate logic.
> 
> It says that if RZ_MTU3 is y/m, PWM_RZ_MTU3 is limited by that.
> But if RZ_MTU3 is n, PWM_RZ_MTU3 can be y or m.
> 
> Is that clearer?

It is, thanks for the explanation!

Cheers,
Fab

> 
> --
> ~Randy