[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <0f38956f-8d23-4f50-8e76-85fc3e225fd6@roeck-us.net>
Date: Tue, 18 Jul 2023 08:07:52 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Henning Schild <henning.schild@...mens.com>
Cc: Lee Jones <lee@...nel.org>, Hans de Goede <hdegoede@...hat.com>,
Wim Van Sebroeck <wim@...ux-watchdog.org>,
linux-kernel@...r.kernel.org, linux-leds@...r.kernel.org,
platform-driver-x86@...r.kernel.org,
linux-watchdog@...r.kernel.org, Pavel Machek <pavel@....cz>,
Mark Gross <markgross@...nel.org>,
Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
Tobias Schaffner <tobias.schaffner@...mens.com>
Subject: Re: [PATCH 1/3] watchdog: make Siemens Simatic watchdog driver
default on platform
On Tue, Jul 18, 2023 at 12:52:11PM +0200, Henning Schild wrote:
> If a user did choose to enable Siemens Simatic platform support they
> likely want that driver to be enabled without having to flip more config
> switches. So we make the watchdog driver config switch default to the
> platform driver switches value.
>
> Signed-off-by: Henning Schild <henning.schild@...mens.com>
> ---
> drivers/watchdog/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
> index ee97d89dfc11..ccdbd1109a32 100644
> --- a/drivers/watchdog/Kconfig
> +++ b/drivers/watchdog/Kconfig
> @@ -1681,6 +1681,7 @@ config NIC7018_WDT
> config SIEMENS_SIMATIC_IPC_WDT
> tristate "Siemens Simatic IPC Watchdog"
> depends on SIEMENS_SIMATIC_IPC
> + default SIEMENS_SIMATIC_IPC
Why not just "default y" ? That does the same (it will be set to m if
SIEMENS_SIMATIC_IPC=m) without the complexity.
Guenter
> select WATCHDOG_CORE
> select P2SB
> help
> --
> 2.41.0
>
Powered by blists - more mailing lists