linux-kernel - Re: [PATCH RESEND v2] staging: fbtft: ili9341: use macro FBTFT_REGISTER_SPI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d3090a47-4bf9-4aef-34f4-6dc06198189b@gmail.com>
Date:   Tue, 18 Jul 2023 18:55:25 +0200
From:   Raphaël Gallais-Pou <rgallaispou@...il.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     dri-devel@...ts.freedesktop.org, linux-fbdev@...r.kernel.org,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH RESEND v2] staging: fbtft: ili9341: use macro
 FBTFT_REGISTER_SPI_DRIVER

Hi,

Le 18/07/2023 à 15:33, Greg Kroah-Hartman a écrit :
> On Tue, Jul 18, 2023 at 10:17:59AM +0200, Raphael Gallais-Pou wrote:
>> Using FBTFT_REGISTER_DRIVER resolves to a NULL struct spi_device_id. This
>> ultimately causes a warning when the module probes. Fixes it.
>>
>> Changes in v2:
>> 	- dropped MODULE_ALIAS changes
>> 	- changed commit log for more accurate description
>>
>> Signed-off-by: Raphael Gallais-Pou <rgallaispou@...il.com>
>> ---
>>   drivers/staging/fbtft/fb_ili9341.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Why is this a resend? >
> And the changes need to go below the --- line as per the documentation.

I messed up the first send and forgot the changelog.
Thanks for your insights, I understand now that I shouldn't have sent a 
'RESEND', but rather a v3 with a third entry in the changelog.

Regards,
Raphaël
> 
> thanks,
> 
> greg k-h