linux-kernel - Re: [PATCH RESEND v2] staging: fbtft: ili9341: use macro FBTFT_REGISTER_SPI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2023071817-enslave-unlovable-f8ae@gregkh>
Date:   Tue, 18 Jul 2023 15:33:35 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Raphael Gallais-Pou <rgallaispou@...il.com>
Cc:     dri-devel@...ts.freedesktop.org, linux-fbdev@...r.kernel.org,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH RESEND v2] staging: fbtft: ili9341: use macro
 FBTFT_REGISTER_SPI_DRIVER

On Tue, Jul 18, 2023 at 10:17:59AM +0200, Raphael Gallais-Pou wrote:
> Using FBTFT_REGISTER_DRIVER resolves to a NULL struct spi_device_id. This
> ultimately causes a warning when the module probes. Fixes it.
> 
> Changes in v2:
> 	- dropped MODULE_ALIAS changes
> 	- changed commit log for more accurate description
> 
> Signed-off-by: Raphael Gallais-Pou <rgallaispou@...il.com>
> ---
>  drivers/staging/fbtft/fb_ili9341.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Why is this a resend?

And the changes need to go below the --- line as per the documentation.

thanks,

greg k-h