[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <e25fb716-38f3-7f4b-d525-e20455cdae85@linaro.org>
Date: Tue, 18 Jul 2023 11:47:27 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
Andy Gross <agross@...nel.org>,
Bjorn Andersson <andersson@...nel.org>,
Konrad Dybcio <konrad.dybcio@...aro.org>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>,
linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: sm8450-hdk: add other analogue
microphones
On 18/07/2023 11:40, Srinivas Kandagatla wrote:
>> diff --git a/arch/arm64/boot/dts/qcom/sm8450-hdk.dts b/arch/arm64/boot/dts/qcom/sm8450-hdk.dts
>> index bd5e8181f2aa..9bd1ef401ca3 100644
>> --- a/arch/arm64/boot/dts/qcom/sm8450-hdk.dts
>> +++ b/arch/arm64/boot/dts/qcom/sm8450-hdk.dts
>> @@ -915,14 +915,23 @@ &sound {
>> "SpkrRight IN", "WSA_SPK2 OUT",
>> "IN1_HPHL", "HPHL_OUT",
>> "IN2_HPHR", "HPHR_OUT",
>> + "AMIC1", "MIC BIAS1",
>> "AMIC2", "MIC BIAS2",
>> - "VA DMIC0", "MIC BIAS1",
>> - "VA DMIC1", "MIC BIAS1",
>> - "VA DMIC2", "MIC BIAS3",
>> - "TX DMIC0", "MIC BIAS1",
>> - "TX DMIC1", "MIC BIAS2",
>> - "TX DMIC2", "MIC BIAS3",
>> - "TX SWR_ADC1", "ADC2_OUTPUT";
>> + "AMIC3", "MIC BIAS3",
>> + "AMIC4", "MIC BIAS3",
>> + "AMIC5", "MIC BIAS4",
> These should reflect the board-level wiring of MIC BIAS, are you sure
> that this is how the hdk is wired up?
If I read the schematics correctly, then yes. You can double check, if I
understood this right: page 40 of HDK schematics
Best regards,
Krzysztof
Powered by blists - more mailing lists