linux-kernel - Re: Re: [PATCH v4 02/17] dt-bindings: gpu: Add Imagination Technologies PowerVR GPU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1cb4f6b57f0826377f0aef85a8abcf0b5f51c07c.camel@imgtec.com>
Date:   Tue, 18 Jul 2023 11:36:03 +0000
From:   Frank Binns <Frank.Binns@...tec.com>
To:     "conor@...nel.org" <conor@...nel.org>,
        "krzysztof.kozlowski@...aro.org" <krzysztof.kozlowski@...aro.org>,
        Sarah Walker <Sarah.Walker@...tec.com>
CC:     "luben.tuikov@....com" <luben.tuikov@....com>,
        "christian.koenig@....com" <christian.koenig@....com>,
        "krzysztof.kozlowski+dt@...aro.org" 
        <krzysztof.kozlowski+dt@...aro.org>,
        "tzimmermann@...e.de" <tzimmermann@...e.de>,
        "mripard@...nel.org" <mripard@...nel.org>,
        "hns@...delico.com" <hns@...delico.com>, "afd@...com" <afd@...com>,
        "daniel@...ll.ch" <daniel@...ll.ch>,
        "maarten.lankhorst@...ux.intel.com" 
        <maarten.lankhorst@...ux.intel.com>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "boris.brezillon@...labora.com" <boris.brezillon@...labora.com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "dakr@...hat.com" <dakr@...hat.com>,
        "matthew.brost@...el.com" <matthew.brost@...el.com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "airlied@...il.com" <airlied@...il.com>,
        "conor+dt@...nel.org" <conor+dt@...nel.org>,
        Donald Robson <Donald.Robson@...tec.com>,
        "faith.ekstrand@...labora.com" <faith.ekstrand@...labora.com>
Subject: Re: Re: [PATCH v4 02/17] dt-bindings: gpu: Add Imagination
 Technologies PowerVR GPU

Hi Krzysztof,

On Tue, 2023-07-18 at 13:10 +0200, Krzysztof Kozlowski wrote:
> On 18/07/2023 13:08, Frank Binns wrote:
> > > And this
> > > items:
> > >   - const: gpu
> > > can just be
> > > const: gpu
> > > 
> > > Although, if there is only one interrupt this is probably not
> > > particularly helpful. Are there other implementations of this IP that
> > > have more interrupts?
> > 
> > No, all our current GPUs just have a single interrupt. I assume it's more future
> > proof to keep the name in case that ever changes? 
> 
> Why do you need name in the first place? If there is single entry, the
> name is pointless, especially if it repeats the name of the IP block.
> 
> > As in, by having the name now
> > we can make it a required property, which I guess we won't be able to do at some
> > later point.
> 
> Why even making it required?

It seems nicer to look up a resource in the driver based on a name rather than
an index. Happy to drop it though.

Thanks
Frank

> 
> Best regards,
> Krzysztof
>