[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <74b666ec-092e-28ea-498b-0efa103d7988@linaro.org>
Date: Tue, 18 Jul 2023 13:52:42 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Frank Binns <Frank.Binns@...tec.com>,
"conor@...nel.org" <conor@...nel.org>,
Sarah Walker <Sarah.Walker@...tec.com>
Cc: "luben.tuikov@....com" <luben.tuikov@....com>,
"christian.koenig@....com" <christian.koenig@....com>,
"krzysztof.kozlowski+dt@...aro.org"
<krzysztof.kozlowski+dt@...aro.org>,
"tzimmermann@...e.de" <tzimmermann@...e.de>,
"mripard@...nel.org" <mripard@...nel.org>,
"hns@...delico.com" <hns@...delico.com>, "afd@...com" <afd@...com>,
"daniel@...ll.ch" <daniel@...ll.ch>,
"maarten.lankhorst@...ux.intel.com"
<maarten.lankhorst@...ux.intel.com>,
"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
"boris.brezillon@...labora.com" <boris.brezillon@...labora.com>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"dakr@...hat.com" <dakr@...hat.com>,
"matthew.brost@...el.com" <matthew.brost@...el.com>,
"robh+dt@...nel.org" <robh+dt@...nel.org>,
"airlied@...il.com" <airlied@...il.com>,
"conor+dt@...nel.org" <conor+dt@...nel.org>,
Donald Robson <Donald.Robson@...tec.com>,
"faith.ekstrand@...labora.com" <faith.ekstrand@...labora.com>
Subject: Re: [PATCH v4 02/17] dt-bindings: gpu: Add Imagination Technologies
PowerVR GPU
On 18/07/2023 13:36, Frank Binns wrote:
> Hi Krzysztof,
>
> On Tue, 2023-07-18 at 13:10 +0200, Krzysztof Kozlowski wrote:
>> On 18/07/2023 13:08, Frank Binns wrote:
>>>> And this
>>>> items:
>>>> - const: gpu
>>>> can just be
>>>> const: gpu
>>>>
>>>> Although, if there is only one interrupt this is probably not
>>>> particularly helpful. Are there other implementations of this IP that
>>>> have more interrupts?
>>>
>>> No, all our current GPUs just have a single interrupt. I assume it's more future
>>> proof to keep the name in case that ever changes?
>>
>> Why do you need name in the first place? If there is single entry, the
>> name is pointless, especially if it repeats the name of the IP block.
>>
>>> As in, by having the name now
>>> we can make it a required property, which I guess we won't be able to do at some
>>> later point.
>>
>> Why even making it required?
>
> It seems nicer to look up a resource in the driver based on a name rather than
> an index.
Not really... Slower and confuses people, because then they think order
is flexible.
Best regards,
Krzysztof
Powered by blists - more mailing lists