linux-kernel - Re: [PATCH v4 17/17] arm64: dts: ti: k3-am62-main: Add GPU device node [DO NOT MERGE]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 18 Jul 2023 11:52:49 +0000
From:   Frank Binns <Frank.Binns@...tec.com>
To:     "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "Sarah Walker" <Sarah.Walker@...tec.com>,
        "krzk@...nel.org" <krzk@...nel.org>
CC:     "luben.tuikov@....com" <luben.tuikov@....com>,
        "afd@...com" <afd@...com>,
        Donald Robson <Donald.Robson@...tec.com>,
        "tzimmermann@...e.de" <tzimmermann@...e.de>,
        "matthew.brost@...el.com" <matthew.brost@...el.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "dakr@...hat.com" <dakr@...hat.com>,
        "hns@...delico.com" <hns@...delico.com>,
        "boris.brezillon@...labora.com" <boris.brezillon@...labora.com>,
        "christian.koenig@....com" <christian.koenig@....com>,
        "mripard@...nel.org" <mripard@...nel.org>,
        "faith.ekstrand@...labora.com" <faith.ekstrand@...labora.com>
Subject: Re: [PATCH v4 17/17] arm64: dts: ti: k3-am62-main: Add GPU device
 node [DO NOT MERGE]

Hi Krzysztof,

On Tue, 2023-07-18 at 08:19 +0200, Krzysztof Kozlowski wrote:
> On 14/07/2023 16:30, Sarah Walker wrote:
> > Add the Series AXE GPU node to the AM62 device tree.
> > 
> > Signed-off-by: Sarah Walker <sarah.walker@...tec.com>
> > ---
> >  arch/arm64/boot/dts/ti/k3-am62-main.dtsi | 13 +++++++++++++
> >  1 file changed, 13 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> > index b3e4857bbbe4..ad13414acf18 100644
> > --- a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> > +++ b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> > @@ -892,4 +892,17 @@ mcasp2: audio-controller@...0000 {
> >  		power-domains = <&k3_pds 192 TI_SCI_PD_EXCLUSIVE>;
> >  		status = "disabled";
> >  	};
> > +
> > +        gpu: gpu@...0000 {
> > +                compatible = "ti,am62-gpu", "img,powervr-seriesaxe";
> > +                reg = <0 0x0fd00000 0 0x20000>;
> > +                power-domains = <&k3_pds 187 TI_SCI_PD_EXCLUSIVE>;
> > +                clocks = <&k3_clks 187 0>;
> > +                clock-names = "core";
> > +                interrupts = <GIC_SPI 86 IRQ_TYPE_LEVEL_HIGH>;
> > +                interrupt-names = "gpu";
> > +                #cooling-cells = <2>;
> > +                #cooling-min-level = <0>;
> > +                #cooling-max-level = <3>;
> 
> It does not look like you tested the DTS against bindings. Please run
> `make dtbs_check` (see
> Documentation/devicetree/bindings/writing-schema.rst or
> https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
> for instructions).

Thank you for the tip. I'll have a read through.

Frank

> 
> Best regards,
> Krzysztof
>