[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <159ca9b9-0702-b347-3e4f-66272dfce55e@ideasonboard.com>
Date: Tue, 18 Jul 2023 16:31:54 +0300
From: Tomi Valkeinen <tomi.valkeinen@...asonboard.com>
To: Harshit Mogalapalli <harshit.m.mogalapalli@...cle.com>,
Mauro Carvalho Chehab <mchehab@...nel.org>,
Sakari Ailus <sakari.ailus@...ux.intel.com>,
Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Cc: dan.carpenter@...aro.org, kernel-janitors@...r.kernel.org,
error27@...il.com
Subject: Re: [PATCH next] media: i2c: fix error handling in
ub960_rxport_add_serializer()
Hi,
On 18/07/2023 11:58, Harshit Mogalapalli wrote:
> Smatch warns:
> drivers/media/i2c/ds90ub960.c:1671 ub960_rxport_add_serializer():
> err: 'rxport->ser.client' dereferencing possible ERR_PTR()
>
> i2c_new_client_device() returns error pointers on failure and in
> dev_dbg statement we are dereferencing error pointer which is a bug.
>
> Fix this by using IS_ERR() which checks for error pointers.
>
> Fixes: afe267f2d368 ("media: i2c: add DS90UB960 driver")
> Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@...cle.com>
> ---
> Found with static analysis, only compile tested. Although in
> drivers/media i2c_client_has_driver() checks are present, IS_ERR() would
> probably be sufficient here.
> ---
> drivers/media/i2c/ds90ub960.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/i2c/ds90ub960.c b/drivers/media/i2c/ds90ub960.c
> index e101bcf2356a..88144e3ec183 100644
> --- a/drivers/media/i2c/ds90ub960.c
> +++ b/drivers/media/i2c/ds90ub960.c
> @@ -1662,7 +1662,7 @@ static int ub960_rxport_add_serializer(struct ub960_data *priv, u8 nport)
> ser_info.addr = rxport->ser.alias;
> rxport->ser.client =
> i2c_new_client_device(priv->client->adapter, &ser_info);
> - if (!rxport->ser.client) {
> + if (IS_ERR(rxport->ser.client)) {
> dev_err(dev, "rx%u: cannot add %s i2c device", nport,
> ser_info.type);
> return -EIO;
Good catch. I think this should be modified to return
PTR_ERR(rxport->ser.client) instead of -EIO. Do you want to update the
patch or shall I do the change?
Tomi
Powered by blists - more mailing lists