linux-kernel - Re: [PATCH] drm/pl111: Fix missing unwind goto in pl111_amba

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87y1jbipf8.fsf@minerva.mail-host-address-is-not-set>
Date:   Wed, 19 Jul 2023 23:04:11 +0200
From:   Javier Martinez Canillas <javierm@...hat.com>
To:     Harshit Mogalapalli <harshit.m.mogalapalli@...cle.com>,
        emma@...olt.net, eric@...olt.net, tom.cooksey@....com
Cc:     error27@...il.com, linux-kernel@...r.kernel.org,
        dri-devel@...ts.freedesktop.org,
        Harshit Mogalapalli <harshit.m.mogalapalli@...cle.com>
Subject: Re: [PATCH] drm/pl111: Fix missing unwind goto in pl111_amba_probe()

Harshit Mogalapalli <harshit.m.mogalapalli@...cle.com> writes:

> Smatch reports:
> 	drivers/gpu/drm/pl111/pl111_drv.c:300
> 	pl111_amba_probe() warn: missing unwind goto?
>
> When devm_request_irq() returns non-zero value, we need to drop the
> reference for drm device and also release reserved memory which is
> done in "dev_put" label. So instead of directly returning, goto dev_put
> to fix this bug.
>
> Fixes: bed41005e617 ("drm/pl111: Initial drm/kms driver for pl111")
> Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@...cle.com>
> ---
> This is based on static analysis, Only Compile tested.
> ---
>  drivers/gpu/drm/pl111/pl111_drv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

The patch looks correct to me.

Reviewed-by: Javier Martinez Canillas <javierm@...hat.com>

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat