linux-kernel - Re: [PATCH] clk: imx93: Propagate correct error in imx93_clocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0f12361faf464ea6c6d0313d1dc54f90.sboyd@kernel.org>
Date:   Wed, 19 Jul 2023 14:05:35 -0700
From:   Stephen Boyd <sboyd@...nel.org>
To:     Abel Vesa <abelvesa@...nel.org>,
        Dan Carpenter <dan.carpenter@...aro.org>,
        Fabio Estevam <festevam@...il.com>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Michael Turquette <mturquette@...libre.com>,
        Peng Fan <peng.fan@....com>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Shawn Guo <shawnguo@...nel.org>,
        Zhanhao Hu <zero12113@...t.edu.cn>
Cc:     NXP Linux Team <linux-imx@....com>,
        kernel test robot <lkp@...el.com>, linux-clk@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Geert Uytterhoeven <geert+renesas@...der.be>
Subject: Re: [PATCH] clk: imx93: Propagate correct error in imx93_clocks_probe()

Quoting Geert Uytterhoeven (2023-07-11 08:08:12)
> smatch reports:
> 
>     drivers/clk/imx/clk-imx93.c:294 imx93_clocks_probe() error: uninitialized symbol 'base'.
> 
> Indeed, in case of an error, the wrong (yet uninitialized) variable is
> converted to an error code and returned.
> Fix this by propagating the error code in the correct variable.
> 
> Fixes: e02ba11b45764705 ("clk: imx93: fix memory leak and missing unwind goto in imx93_clocks_probe")
> Reported-by: Dan Carpenter <dan.carpenter@...aro.org>
> Closes: https://lore.kernel.org/all/9c2acd81-3ad8-485d-819e-9e4201277831@kadam.mountain
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/all/202306161533.4YDmL22b-lkp@intel.com/
> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>
> ---

Applied to clk-fixes