[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <c5e71fa4-ad39-f958-4eca-887f60544f54@kernel.org>
Date: Wed, 19 Jul 2023 07:37:50 +0200
From: Jiri Slaby <jirislaby@...nel.org>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: Tony Lindgren <tony@...mide.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Dhruva Gole <d-gole@...com>,
Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
John Ogness <john.ogness@...utronix.de>,
Johan Hovold <johan@...nel.org>,
Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
Vignesh Raghavendra <vigneshr@...com>,
linux-omap@...r.kernel.org, linux-serial@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] serial: core: Fix serial core port id to not use
port->line
On 19. 07. 23, 7:34, Andy Shevchenko wrote:
> On Wed, Jul 19, 2023 at 07:26:41AM +0200, Jiri Slaby wrote:
>> On 19. 07. 23, 7:12, Tony Lindgren wrote:
>
> ...
>
>>> int ctrl_id; /* optional serial core controller id */
>>> + int port_id; /* optional serial core port id */
>>
>> Can the id be negative? If not, please use uint.
>
> Does this suggestion apply to ctrl_id as well?
Sure, but he hasn't added it in this series ;). So it should go to
someone's todo :P.
--
js
suse labs
Powered by blists - more mailing lists