linux-kernel - Re: [PATCH] serial: core: Fix serial core port id to not use port->line

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230719055033.GL5194@atomide.com>
Date:   Wed, 19 Jul 2023 08:50:33 +0300
From:   Tony Lindgren <tony@...mide.com>
To:     Jiri Slaby <jirislaby@...nel.org>
Cc:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Dhruva Gole <d-gole@...com>,
        Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
        John Ogness <john.ogness@...utronix.de>,
        Johan Hovold <johan@...nel.org>,
        Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
        Vignesh Raghavendra <vigneshr@...com>,
        linux-omap@...r.kernel.org, linux-serial@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] serial: core: Fix serial core port id to not use
 port->line

* Jiri Slaby <jirislaby@...nel.org> [230719 05:37]:
> On 19. 07. 23, 7:34, Andy Shevchenko wrote:
> > On Wed, Jul 19, 2023 at 07:26:41AM +0200, Jiri Slaby wrote:
> > > On 19. 07. 23, 7:12, Tony Lindgren wrote:
> > 
> > ...
> > 
> > > >    	int			ctrl_id;		/* optional serial core controller id */
> > > > +	int			port_id;		/* optional serial core port id */
> > > 
> > > Can the id be negative? If not, please use uint.
> > 
> > Does this suggestion apply to ctrl_id as well?
> 
> Sure, but he hasn't added it in this series ;). So it should go to someone's
> todo :P.

Yes it can be uint, that's left over from some earlier revision where -ENODEV
was used, will fix that too.

Regards,

Tony