linux-kernel - Re: [PATCH v4 3/4] dt-bindings: soc: mediatek: pwrap: Modify compatible for MT8188

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ae40d54a-1599-a954-b18f-263196766a2d@collabora.com>
Date:   Wed, 19 Jul 2023 09:15:51 +0200
From:   AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>
To:     Jason-ch Chen <jason-ch.chen@...iatek.com>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Matthias Brugger <matthias.bgg@...il.com>
Cc:     Nícolas F . R . A . Prado 
        <nfraprado@...labora.com>, Chen-Yu Tsai <wenst@...omium.org>,
        Project_Global_Chrome_Upstream_Group@...iatek.com,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH v4 3/4] dt-bindings: soc: mediatek: pwrap: Modify
 compatible for MT8188

Il 18/07/23 13:09, Jason-ch Chen ha scritto:
> From: jason-ch chen <Jason-ch.Chen@...iatek.com>
> 
> The reason for changing the patch was that while MT8188 uses the same
> pwrap as MT8195, the original code was only applicable to 'compatible =
> "mediatek,mt8188-pwrap"'. To resolve the DTBS check warning that
> '['mediatek,mt8188-pwrap', 'mediatek,mt8195-pwrap', 'syscon'] is too
> long', it is necessary to modify the code.
> 
> Signed-off-by: jason-ch chen <Jason-ch.Chen@...iatek.com>

The original binding allowed only "mediatek,mt8188-pwrap", while we need
to specify

compatible = "mediatek,mt8188-pwrap", "mediatek,mt8195-pwrap", "syscon";

for this node, as MT8188's PWRAP is fully compatible with MT8195 as it is
the very same IP, hence:

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>

Regards,
Angelo

> ---
>   .../devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml    | 6 +++++-
>   1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml b/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml
> index a06ac2177444..4737e5f45d54 100644
> --- a/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml
> +++ b/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml
> @@ -41,7 +41,6 @@ properties:
>                 - mediatek,mt8173-pwrap
>                 - mediatek,mt8183-pwrap
>                 - mediatek,mt8186-pwrap
> -              - mediatek,mt8188-pwrap
>                 - mediatek,mt8195-pwrap
>                 - mediatek,mt8365-pwrap
>                 - mediatek,mt8516-pwrap
> @@ -50,6 +49,11 @@ properties:
>                 - mediatek,mt8186-pwrap
>                 - mediatek,mt8195-pwrap
>             - const: syscon
> +      - items:
> +          - enum:
> +              - mediatek,mt8188-pwrap
> +          - const: mediatek,mt8195-pwrap
> +          - const: syscon
>   
>     reg:
>       minItems: 1