linux-kernel - Re: [PATCH v4 3/4] dt-bindings: soc: mediatek: pwrap: Modify compatible for MT8188

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 19 Jul 2023 01:48:28 +0000
From:   Jason-ch Chen (陳建豪) 
        <Jason-ch.Chen@...iatek.com>
To:     "conor@...nel.org" <conor@...nel.org>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "linux-mediatek@...ts.infradead.org" 
        <linux-mediatek@...ts.infradead.org>,
        "wenst@...omium.org" <wenst@...omium.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        Project_Global_Chrome_Upstream_Group 
        <Project_Global_Chrome_Upstream_Group@...iatek.com>,
        "conor+dt@...nel.org" <conor+dt@...nel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "krzysztof.kozlowski+dt@...aro.org" 
        <krzysztof.kozlowski+dt@...aro.org>,
        "matthias.bgg@...il.com" <matthias.bgg@...il.com>,
        "angelogioacchino.delregno@...labora.com" 
        <angelogioacchino.delregno@...labora.com>,
        "nfraprado@...labora.com" <nfraprado@...labora.com>
Subject: Re: [PATCH v4 3/4] dt-bindings: soc: mediatek: pwrap: Modify
 compatible for MT8188

Hi Conor,

On Tue, 2023-07-18 at 16:13 +0100, Conor Dooley wrote:
> On Tue, Jul 18, 2023 at 07:09:46PM +0800, Jason-ch Chen wrote:
> > From: jason-ch chen <Jason-ch.Chen@...iatek.com>
> > 
> > The reason for changing the patch was that while MT8188 uses the
> > same
> > pwrap as MT8195,
> > the original code was only applicable to 'compatible =
> > "mediatek,mt8188-pwrap"'.
> 
> I don't really understand what this means. Did you mean, "the
> original
> binding only allowed..."? If so,
> Acked-by: Conor Dooley <conor.dooley@...rochip.com>
> 

Thank you for your reply.
The actual test results confirm that the original binding is only
allowed to 'compatible = "mediatek,mt8188-pwrap"'.

> Thanks,
> Conor.
> 
> > To resolve the DTBS check warning that
> > '['mediatek,mt8188-pwrap', 'mediatek,mt8195-pwrap', 'syscon'] is
> > too
> > long', it is necessary to modify the code.
> > 
> > Signed-off-by: jason-ch chen <Jason-ch.Chen@...iatek.com>
> > ---
> >  .../devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml    | 6
> > +++++-
> >  1 file changed, 5 insertions(+), 1 deletion(-)
> > 
> > diff --git
> > a/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yam
> > l
> > b/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yam
> > l
> > index a06ac2177444..4737e5f45d54 100644
> > ---
> > a/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yam
> > l
> > +++
> > b/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yam
> > l
> > @@ -41,7 +41,6 @@ properties:
> >                - mediatek,mt8173-pwrap
> >                - mediatek,mt8183-pwrap
> >                - mediatek,mt8186-pwrap
> > -              - mediatek,mt8188-pwrap
> >                - mediatek,mt8195-pwrap
> >                - mediatek,mt8365-pwrap
> >                - mediatek,mt8516-pwrap
> > @@ -50,6 +49,11 @@ properties:
> >                - mediatek,mt8186-pwrap
> >                - mediatek,mt8195-pwrap
> >            - const: syscon
> > +      - items:
> > +          - enum:
> > +              - mediatek,mt8188-pwrap
> > +          - const: mediatek,mt8195-pwrap
> > +          - const: syscon
> >  
> >    reg:
> >      minItems: 1
> > -- 
> > 2.18.0

Regards,
Jason