linux-kernel - Re: [PATCH] arm64: dts: qcom: sdm630: remove refs to nonexistent clocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b8cc0229-d663-3527-b320-51a48b4af5b5@postmarketos.org>
Date:   Wed, 19 Jul 2023 11:36:46 +0300
From:   Alexey Minnekhanov <alexeymin@...tmarketos.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     ~postmarketos/upstreaming@...ts.sr.ht, phone-devel@...r.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: sdm630: remove refs to nonexistent
 clocks

On 19.07.2023 10:39, Krzysztof Kozlowski wrote:
> On 19/07/2023 09:35, Alexey Minnekhanov wrote:
>> Since commit d6edc31f3a68 ("clk: qcom: smd-rpm: Separate out
>> interconnect bus clocks") rpmcc-sdm660 no longer provides
>> RPM_SMD_AGGR2_NOC_CLK and RPM_SMD_AGGR2_NOC_A_CLK clocks.
>> Remove them to fix various probe failures and get devices
>> booting again.
> 
> So that commit broke DTS?
> 

Yes, this is my understanding of the situation.
The commit in subject [1] is only in linux-next for a few days, so it 
broke booting only on 6.5-rc (rc2 currently). Konrad said: "these clocks 
references were API abuses; referencing the bus clocks was circumventing 
the interconnect layer. That loophole is now gone and the abusers are 
now apparent"

> 
> It does not look like you tested the DTS against bindings. Please run
> `make dtbs_check`
> 

If DT schema for interconnect requires bus clocks to be specified, I 
don't even know what to put there now. Can we change schema?

[1] 
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=d6edc31f3a68d8d0636e0cfcd9eced7460ad32f4

-- 
Regards,
Alexey Minnekhanov
postmarketOS developer