linux-kernel - Re: [PATCH v1] led: flash: various minor fixes for leds-qcom-flash driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c22e59ef-918f-81ba-99e8-87815949fc1a@quicinc.com>
Date:   Wed, 19 Jul 2023 16:52:03 +0800
From:   Fenglin Wu <quic_fenglinw@...cinc.com>
To:     Lee Jones <lee@...nel.org>
CC:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        <linux-arm-msm@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <pavel@....cz>, ChiaEn Wu <chiaen_wu@...htek.com>,
        Alice Chen <alice_chen@...htek.com>,
        ChiYuan Huang <cy_huang@...htek.com>,
        "Dylan Van Assche" <me@...anvanassche.be>,
        Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>,
        Tom Rix <trix@...hat.com>, <linux-leds@...r.kernel.org>,
        <quic_collinsd@...cinc.com>, <quic_subbaram@...cinc.com>
Subject: Re: [PATCH v1] led: flash: various minor fixes for leds-qcom-flash
 driver



On 7/19/2023 4:50 PM, Lee Jones wrote:
> On Tue, 18 Jul 2023, Fenglin Wu wrote:
> 
>>
>>
>> On 7/18/2023 5:32 PM, Krzysztof Kozlowski wrote:
>>> On 18/07/2023 11:24, Fenglin Wu wrote:
>>>> Update the driver to address following minor issues:
>>>>    - Add a sentence in Kconfig to explain the driver can be compiled
>>>>      as a module
>>>>    - strobe off the LED channel before setting flash current to prevent
>>>>      the flash LED being lit with an incorrect brightness if it was
>>>>      already active in torch mode
>>>>    - put the child node if register any flash LED device failed.
>>>
>>> Don't mix different fixes and changes in one commit.
>>>
>>> Also, please use scripts/get_maintainers.pl to get a list of necessary
>>> people and lists to CC (and consider --no-git-fallback argument). I
>>> really do not see a point why I am cc-ed here.
>>>
>>> Best regards,
>>> Krzysztof
>>
>> I understood that we should separate the changes for different fixes.
>>
>> I am trying to address the review comment from Pavel that was coming late
>> after the original changes were applied:
>> https://lore.kernel.org/linux-arm-msm/20230325170957.GA2904@bug/ (sorry for
>> just got time to work on this), since all of them are small ones and all
>> related with the same driver, so I thought it might be good to put them
>> together and update with a single patch?
> 
> Separate patches - one per functional change please.
sure. I will separate them and send them out.
Thanks

>