linux-kernel - Re: [PATCH v2] arm64: dts: imx8mn-var-som-symphony: fix USB OTG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230719020035.GS9559@dragon>
Date:   Wed, 19 Jul 2023 10:00:35 +0800
From:   Shawn Guo <shawnguo@...nel.org>
To:     Hugo Villeneuve <hugo@...ovil.com>
Cc:     Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Fabio Estevam <festevam@...il.com>,
        NXP Linux Team <linux-imx@....com>,
        Hugo Villeneuve <hvilleneuve@...onoff.com>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] arm64: dts: imx8mn-var-som-symphony: fix USB OTG

On Tue, Jul 18, 2023 at 10:03:44AM -0400, Hugo Villeneuve wrote:
> On Tue, 18 Jul 2023 14:37:15 +0800
> Shawn Guo <shawnguo@...nel.org> wrote:
> 
> > On Wed, Jul 05, 2023 at 01:49:32PM -0400, Hugo Villeneuve wrote:
> > > From: Hugo Villeneuve <hvilleneuve@...onoff.com>
> > > 
> > > USB OTG is currently broken on the Variscite Symphony EVK and imx8mn
> > > nano SOM.
> > > 
> > > The PTN5150 circuitry on newer versions of the Symphony EVK board has
> > > a non-standard configuration in which the PTN5150 IRQ pin is left
> > > unconnected, and the PTN5150 ID pin is connected to GPIO1_IO11. This
> > > requires changes to the ptn5150 driver to support this new mode.
> > > Variscite have indicated their intention to submit those changes
> > > upstream.
> > > 
> > > In the meantime, import device tree changes from linux-5.15 branch of
> > > varigit repos to at least make the USB OTG port operate correctly in
> > > host mode.
> > > 
> > > Fixes: 7358e05bddca ("arm64: dts: imx8mn-var-som-symphony: Add Variscite Symphony board with VAR-SOM-MX8MN")
> > 
> > Has USB OTG been ever worked at all?  If the answer is no, it's not
> > a fix but a new feature, and I would suggest you rework the patch
> > subject and drop the Fixes tag.
> 
> Hi Shawn,
> it never worked for me since commit 7358e05bddca, but it may have
> something to do with the new hardware board version (>=1.4a) that I
> have. It probably worked for older boards (< 1.4a) altough I cannot
> confirm it without old hardware.
> 
> Let me know if you want me to remove the Fixes tag.

The change doesn't look like a bug fix as it stands.  Please rework the
patch subject and remove the Fixes tag.

Shawn