[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <6d503477-82eb-c201-129a-009bcde485d0@starfivetech.com>
Date: Thu, 20 Jul 2023 14:12:51 +0800
From: Walker Chen <walker.chen@...rfivetech.com>
To: Rob Herring <robh@...nel.org>, Conor Dooley <conor@...nel.org>
CC: <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] soc: starfive: Explicitly include correct DT includes
On 2023/7/15 1:51, Rob Herring wrote:
> The DT of_device.h and of_platform.h date back to the separate
> of_platform_bus_type before it as merged into the regular platform bus.
> As part of that merge prepping Arm DT support 13 years ago, they
> "temporarily" include each other. They also include platform_device.h
> and of.h. As a result, there's a pretty much random mix of those include
> files used throughout the tree. In order to detangle these headers and
> replace the implicit includes with struct declarations, users need to
> explicitly include the correct includes.
>
> Signed-off-by: Rob Herring <robh@...nel.org>
> ---
> drivers/soc/starfive/jh71xx_pmu.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/soc/starfive/jh71xx_pmu.c b/drivers/soc/starfive/jh71xx_pmu.c
> index 7d5f50d71c0d..d3b78a619d40 100644
> --- a/drivers/soc/starfive/jh71xx_pmu.c
> +++ b/drivers/soc/starfive/jh71xx_pmu.c
> @@ -10,7 +10,6 @@
> #include <linux/iopoll.h>
> #include <linux/module.h>
> #include <linux/of.h>
> -#include <linux/of_device.h>
> #include <linux/platform_device.h>
> #include <linux/pm_domain.h>
> #include <dt-bindings/power/starfive,jh7110-pmu.h>
Nice! Thank you for your careful discovery, this helps simplify the code.
Best regards,
Walker
Powered by blists - more mailing lists