linux-kernel - Re: [PATCH] soc: starfive: Explicitly include correct DT includes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230720-captive-wife-8bdd341fa8f5@wendy>
Date:   Thu, 20 Jul 2023 08:12:54 +0100
From:   Conor Dooley <conor.dooley@...rochip.com>
To:     Walker Chen <walker.chen@...rfivetech.com>
CC:     Rob Herring <robh@...nel.org>, Conor Dooley <conor@...nel.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] soc: starfive: Explicitly include correct DT includes

On Thu, Jul 20, 2023 at 02:12:51PM +0800, Walker Chen wrote:
> On 2023/7/15 1:51, Rob Herring wrote:
> > The DT of_device.h and of_platform.h date back to the separate
> > of_platform_bus_type before it as merged into the regular platform bus.
> > As part of that merge prepping Arm DT support 13 years ago, they
> > "temporarily" include each other. They also include platform_device.h
> > and of.h. As a result, there's a pretty much random mix of those include
> > files used throughout the tree. In order to detangle these headers and
> > replace the implicit includes with struct declarations, users need to
> > explicitly include the correct includes.
> > 
> > Signed-off-by: Rob Herring <robh@...nel.org>
> > ---
> >  drivers/soc/starfive/jh71xx_pmu.c | 1 -
> >  1 file changed, 1 deletion(-)
> > 
> > diff --git a/drivers/soc/starfive/jh71xx_pmu.c b/drivers/soc/starfive/jh71xx_pmu.c
> > index 7d5f50d71c0d..d3b78a619d40 100644
> > --- a/drivers/soc/starfive/jh71xx_pmu.c
> > +++ b/drivers/soc/starfive/jh71xx_pmu.c
> > @@ -10,7 +10,6 @@
> >  #include <linux/iopoll.h>
> >  #include <linux/module.h>
> >  #include <linux/of.h>
> > -#include <linux/of_device.h>
> >  #include <linux/platform_device.h>
> >  #include <linux/pm_domain.h>
> >  #include <dt-bindings/power/starfive,jh7110-pmu.h>
> 
> Nice! Thank you for your careful discovery, this helps simplify the code.

Huh, seems I missed this patch. Now applied, thanks!

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)