linux-kernel - Re: [PATCH v2 00/11] Unify TDCALL/SEAMCALL and TDVMCALL assembly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230720131608.GE3569127@hirez.programming.kicks-ass.net>
Date:   Thu, 20 Jul 2023 15:16:08 +0200
From:   Peter Zijlstra <peterz@...radead.org>
To:     Kai Huang <kai.huang@...el.com>
Cc:     kirill.shutemov@...ux.intel.com, linux-kernel@...r.kernel.org,
        dave.hansen@...el.com, tglx@...utronix.de, bp@...en8.de,
        mingo@...hat.com, hpa@...or.com, x86@...nel.org, seanjc@...gle.com,
        pbonzini@...hat.com, isaku.yamahata@...el.com,
        sathyanarayanan.kuppuswamy@...ux.intel.com,
        n.borisov.lkml@...il.com
Subject: Re: [PATCH v2 00/11] Unify TDCALL/SEAMCALL and TDVMCALL assembly

On Fri, Jul 21, 2023 at 12:28:03AM +1200, Kai Huang wrote:

> Kai Huang (11):
>   x86/tdx: Zero out the missing RSI in TDX_HYPERCALL macro
>   x86/tdx: Skip saving output regs when SEAMCALL fails with
>     VMFailInvalid
>   x86/tdx: Make macros of TDCALLs consistent with the spec
>   x86/tdx: Rename __tdx_module_call() to __tdcall()
>   x86/tdx: Pass TDCALL/SEAMCALL input/output registers via a structure
>   x86/tdx: Extend TDX_MODULE_CALL to support more TDCALL/SEAMCALL leafs
>   x86/tdx: Make TDX_HYPERCALL asm similar to TDX_MODULE_CALL
>   x86/tdx: Reimplement __tdx_hypercall() using TDX_MODULE_CALL asm
>   x86/tdx: Remove 'struct tdx_hypercall_args'
>   x86/virt/tdx: Wire up basic SEAMCALL functions
>   x86/virt/tdx: Allow SEAMCALL to handle #UD and #GP

These look ok to me, thanks!

This does not yet re-order the args structure to conform to the hardware
index order as per kvm's requirement, right? That will be part of the
KVM series?