[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <68485bf5-0550-4954-cbaa-7f6a5443e4aa@kernel.org>
Date: Fri, 21 Jul 2023 18:22:50 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Florian Fainelli <f.fainelli@...il.com>,
"Ng, Boon Khai" <boon.khai.ng@...el.com>,
"Boon@...mtp.png.intel.com" <Boon@...mtp.png.intel.com>,
"Khai@...mtp.png.intel.com" <Khai@...mtp.png.intel.com>,
Giuseppe Cavallaro <peppe.cavallaro@...com>,
Alexandre Torgue <alexandre.torgue@...s.st.com>,
Jose Abreu <joabreu@...opsys.com>,
"David S . Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>,
Maxime Coquelin <mcoquelin.stm32@...il.com>,
"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
"linux-stm32@...md-mailman.stormreply.com"
<linux-stm32@...md-mailman.stormreply.com>,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Cc: "Shevchenko, Andriy" <andriy.shevchenko@...el.com>,
"Tham, Mun Yew" <mun.yew.tham@...el.com>,
"Swee, Leong Ching" <leong.ching.swee@...el.com>,
"G Thomas, Rohan" <rohan.g.thomas@...el.com>,
Shevchenko Andriy <andriy.shevchenko@...ux.intel.com>
Subject: Re: [Enable Designware XGMAC VLAN Stripping Feature 2/2] net: stmmac:
dwxgmac2: Add support for HW-accelerated VLAN Stripping
On 21/07/2023 17:59, Florian Fainelli wrote:
>>>> + /* Rx VLAN HW Stripping */
>>>> + if (of_property_read_bool(np, "snps,rx-vlan-offload")) {
>>>> + dev_info(&pdev->dev, "RX VLAN HW Stripping\n");
>>>
>>> Why? Drop.
>>>
>>
>> This is an dts option export to dts for user to choose whether or not they
>> Want a Hardware stripping or a software stripping.
>>
>> May I know what is the reason to drop this?
>
> Because the networking stack already exposes knobs for drivers to
> advertise and control VLAN stripping/insertion on RX/TX using ethtool
> and feature bits (NETIF_F_HW_VLAN_CTAG_RX, NETIF_F_HW_VLAN_CTAG_TX).
>
> What you are doing here is encode a policy as a Device Tree property
> rather than describe whether the hardware supports a given feature and
> this is frowned upon.
That's even better reason...
Best regards,
Krzysztof
Powered by blists - more mailing lists