linux-kernel - Re: [tip: x86/shstk] mm: Don't allow write GUPs to shadow stack memory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1b5d436e1b4f31c37ce1f1e6342c836fd5b2ceec.camel@intel.com>
Date:   Fri, 21 Jul 2023 16:24:45 +0000
From:   "Edgecombe, Rick P" <rick.p.edgecombe@...el.com>
To:     "mingo@...nel.org" <mingo@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     "david@...hat.com" <david@...hat.com>,
        "Xu, Pengfei" <pengfei.xu@...el.com>,
        "linux-tip-commits@...r.kernel.org" 
        <linux-tip-commits@...r.kernel.org>, "bp@...en8.de" <bp@...en8.de>,
        "dave.hansen@...ux.intel.com" <dave.hansen@...ux.intel.com>,
        "keescook@...omium.org" <keescook@...omium.org>,
        "john.allen@....com" <john.allen@....com>,
        "rppt@...nel.org" <rppt@...nel.org>,
        "x86@...nel.org" <x86@...nel.org>
Subject: Re: [tip: x86/shstk] mm: Don't allow write GUPs to shadow stack
 memory

On Fri, 2023-07-21 at 10:34 +0200, Ingo Molnar wrote:
> 
> * tip-bot2 for Rick Edgecombe <tip-bot2@...utronix.de> wrote:
> 
> > The following commit has been merged into the x86/shstk branch of
> > tip:
> > 
> > Commit-ID:     7c8f82db8acb9f0935703c0d96cda552bbf91ff2
> > Gitweb:       
> > https://git.kernel.org/tip/7c8f82db8acb9f0935703c0d96cda552bbf91ff2
> > Author:        Rick Edgecombe <rick.p.edgecombe@...el.com>
> > AuthorDate:    Mon, 12 Jun 2023 17:10:48 -07:00
> > Committer:     Rick Edgecombe <rick.p.edgecombe@...el.com>
> > CommitterDate: Tue, 11 Jul 2023 14:12:47 -07:00
> > 
> > mm: Don't allow write GUPs to shadow stack memory
> 
> JFYI, this commit was the last user of
> writable_file_mapping_allowed(), 
> which breaks the x86-defconfig build:
> 
>   mm/gup.c:1015:13: error: ‘writable_file_mapping_allowed’ defined
> but not used [-Werror=unused-function]
> 
> There's also a now orphan reference to
> writable_file_mapping_allowed() in 
> the comment of folio_fast_pin_allowed().

Oh, thanks for letting me know. It looks like a rebase error on my
part. This hunk should not have been dropped in that commit:
-		if (!vma_anon &&
-		    !writable_file_mapping_allowed(vma, gup_flags))
-			return -EFAULT;
Then writable_file_mapping_allowed() would still have a reference.

As for the build breakage, I'm not sure how this slipped through. My
runtime test environment was missing CONFIG_WERROR, but I got 0day
build successes for the x86_64 and i386 defconfigs specifically. I'll
have to follow up with the 0day people.

Rick