linux-kernel - Re: [tip: x86/shstk] mm: Don't allow write GUPs to shadow stack memory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZLpC/IbswCA0yUHD@gmail.com>
Date:   Fri, 21 Jul 2023 10:34:04 +0200
From:   Ingo Molnar <mingo@...nel.org>
To:     linux-kernel@...r.kernel.org
Cc:     linux-tip-commits@...r.kernel.org,
        Rick Edgecombe <rick.p.edgecombe@...el.com>,
        Dave Hansen <dave.hansen@...ux.intel.com>,
        "Borislav Petkov (AMD)" <bp@...en8.de>,
        Kees Cook <keescook@...omium.org>,
        "Mike Rapoport (IBM)" <rppt@...nel.org>,
        David Hildenbrand <david@...hat.com>,
        Pengfei Xu <pengfei.xu@...el.com>,
        John Allen <john.allen@....com>, x86@...nel.org
Subject: Re: [tip: x86/shstk] mm: Don't allow write GUPs to shadow stack
 memory


* tip-bot2 for Rick Edgecombe <tip-bot2@...utronix.de> wrote:

> The following commit has been merged into the x86/shstk branch of tip:
> 
> Commit-ID:     7c8f82db8acb9f0935703c0d96cda552bbf91ff2
> Gitweb:        https://git.kernel.org/tip/7c8f82db8acb9f0935703c0d96cda552bbf91ff2
> Author:        Rick Edgecombe <rick.p.edgecombe@...el.com>
> AuthorDate:    Mon, 12 Jun 2023 17:10:48 -07:00
> Committer:     Rick Edgecombe <rick.p.edgecombe@...el.com>
> CommitterDate: Tue, 11 Jul 2023 14:12:47 -07:00
> 
> mm: Don't allow write GUPs to shadow stack memory

JFYI, this commit was the last user of writable_file_mapping_allowed(), 
which breaks the x86-defconfig build:

  mm/gup.c:1015:13: error: ‘writable_file_mapping_allowed’ defined but not used [-Werror=unused-function]

There's also a now orphan reference to writable_file_mapping_allowed() in 
the comment of folio_fast_pin_allowed().

Thanks,

	Ingo