[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230721062735.GA9068@linuxcarl2.richtek.com>
Date: Fri, 21 Jul 2023 14:27:35 +0800
From: Alina Yu <alina_yu@...htek.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
CC: <lgirdwood@...il.com>, <broonie@...nel.org>, <robh+dt@...nel.org>,
<krzysztof.kozlowski+dt@...aro.org>, <conor+dt@...nel.org>,
<linux-kernel@...r.kernel.org>, <devicetree@...r.kernel.org>,
<alina_yu@...htek.com>
Subject: Re: [PATCH v4 1/2] regulator: dt-bindings: rtq2208: Add Richtek
RTQ2208 SubPMIC
Hi,
Krzysztof:
> > ...
> >
> >>> +
> >>> + regulator-mode:
> >>> + enum: [0, 1]
> >>> + description:
> >>> + describe buck initial operating mode in suspend state.
> >>
> >> There is no such property on this level. Aren't you mixing initial one?
> >
> > It's the initial mode in suspend-mem state, should I modify that like this ?
> > patternProperties:
> > "^regulator-state-(standby|mem|disk)$":
> > type: object
> > $ref: regulator.yaml#
> > properties:
> > regulator-mode:
> > enum: [0, 1]
> > description:
> > describe byck initial operating mode in suspend state.
>
> Please check how other bindings do it.
>
If I modify that like this, will it be correct ?
...
regulator-state-mem:
type: object
$ref: regulator.yaml#
properties:
regulator-mode:
description:
describe buck initial operating mode in suspend state.
0 - Auto mode
1 - FCCM
Best regards,
Alina
Powered by blists - more mailing lists