linux-kernel - Re: [PATCH] include: events: remove spaces after '(' and before ')'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230723111258.4e72787a@gandalf.local.home>
Date:   Sun, 23 Jul 2023 11:12:58 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     sunran001@...suo.com
Cc:     mhiramat@...nel.org, linux-kernel@...r.kernel.org,
        linux-trace-kernel@...r.kernel.org
Subject: Re: [PATCH] include: events: remove spaces after '(' and before ')'

On Wed, 19 Jul 2023 11:21:03 +0800
sunran001@...suo.com wrote:

> Fix four occurrences of the checkpatch error:
> 
> ERROR: space prohibited after that open parenthesis '('
> ERROR: space prohibited before that close parenthesis ')'
> 
> Signed-off-by: Ran Sun <sunran001@...suo.com>
> ---
>   include/trace/events/nmi.h | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/include/trace/events/nmi.h b/include/trace/events/nmi.h
> index 18e0411398ba..99abd0bc8ebd 100644
> --- a/include/trace/events/nmi.h
> +++ b/include/trace/events/nmi.h
> @@ -15,9 +15,9 @@ TRACE_EVENT(nmi_handler,
>   	TP_ARGS(handler, delta_ns, handled),
> 
>   	TP_STRUCT__entry(
> -		__field(	void *,		handler	)
> -		__field(	s64,		delta_ns)
> -		__field(	int,		handled	)
> +		__field(void *,	handler)
> +		__field(s64, delta_ns)
> +		__field(int, handled)

NACK!

Which version looks better?

checkpatch.pl fails horribly on TRACE_EVENT macros. DON'T MODIFY THEM!

-- Steve

>   	),
> 
>   	TP_fast_assign(