linux-kernel - Re: [PATCH] napi: remove spaces after '('

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230723111317.7aadddc0@gandalf.local.home>
Date:   Sun, 23 Jul 2023 11:13:16 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     sunran001@...suo.com
Cc:     mhiramat@...nel.org, linux-kernel@...r.kernel.org,
        linux-trace-kernel@...r.kernel.org
Subject: Re: [PATCH] napi: remove spaces after '('

On Wed, 19 Jul 2023 14:50:11 +0800
sunran001@...suo.com wrote:

> Fix four occurrences of the checkpatch error:
> 
> ERROR: space prohibited after that open parenthesis '('
> 
> Signed-off-by: Ran Sun <sunran001@...suo.com>
> ---
>   include/trace/events/napi.h | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/include/trace/events/napi.h b/include/trace/events/napi.h
> index 6678cf8b235b..98fb9e0d2219 100644
> --- a/include/trace/events/napi.h
> +++ b/include/trace/events/napi.h
> @@ -18,10 +18,10 @@ TRACE_EVENT(napi_poll,
>   	TP_ARGS(napi, work, budget),
> 
>   	TP_STRUCT__entry(
> -		__field(	struct napi_struct *,	napi)
> -		__string(	dev_name, napi->dev ? napi->dev->name : NO_DEV)
> -		__field(	int,			work)
> -		__field(	int,			budget)
> +		__field(struct napi_struct *, napi)
> +		__string(dev_name, napi->dev ? napi->dev->name : NO_DEV)
> +		__field(int, work)
> +		__field(int, budget)


NACK!

Which version looks better?

checkpatch.pl fails horribly on TRACE_EVENT macros. DON'T MODIFY THEM!

-- Steve


>   	),
> 
>   	TP_fast_assign(