linux-kernel - Re: [PATCH v2] ARM: dts: imx: Set default tuning step for imx7d usdhc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 23 Jul 2023 13:38:08 -0300
From:   Fabio Estevam <festevam@...il.com>
To:     Xiaolei Wang <xiaolei.wang@...driver.com>
Cc:     robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
        conor+dt@...nel.org, shawnguo@...nel.org, s.hauer@...gutronix.de,
        linux-imx@....com, richardcochran@...il.com,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] ARM: dts: imx: Set default tuning step for imx7d usdhc

Hi Xiaolei,

On Sat, Jul 22, 2023 at 11:21 PM Xiaolei Wang
<xiaolei.wang@...driver.com> wrote:
>
> If the tuning step is not set, the tuning step is set to 1.
> For some sd cards, the following Tuning timeout will occur,

You missed putting the timeout message here.

> so set the default tuning step. This refers to the NXP vendor's
> commit below:
>
> https://github.com/nxp-imx/linux-imx/blob/lf-6.1.y/
> arch/arm/boot/dts/imx7s.dtsi#L1216-L1217
>
> Fixes: 1e336aa0c025 ("mmc: sdhci-esdhc-imx: correct the tuning start tap and step setting")
> Signed-off-by: Xiaolei Wang <xiaolei.wang@...driver.com>
>
> v2:
>   * Refer to https://github.com/nxp-imx/linux-imx/blob/lf-6.1.y/arch/arm/boot/dts/imx7s.dtsi#L1216-L1217
>     and add the following attributes for all usdhc of imx7:
>       fsl,tuning-step = <2>;
>       fsl,tuning-start-tap = <20>;

This v2 changelog should be placed below the --- line.

> ---

Put it here.

Reviewed-by: Fabio Estevam <festevam@...il.com>