[<prev] [next>] [day] [month] [year] [list]
Message-ID: <59d94e6e-27b6-5b12-d592-8f814ee1788f@oracle.com>
Date: Sun, 23 Jul 2023 11:44:31 -0500
From: Mike Christie <michael.christie@...cle.com>
To: 杜敏杰 <duminjie@...o.com>,
Lee Duncan <lduncan@...e.com>, Chris Leech <cleech@...hat.com>,
"James E.J. Bottomley" <jejb@...ux.ibm.com>,
"Martin K. Petersen" <martin.petersen@...cle.com>,
"open list:ISCSI" <open-iscsi@...glegroups.com>,
"open list:ISCSI" <linux-scsi@...r.kernel.org>,
open list <linux-kernel@...r.kernel.org>
Cc: "opensource.kernel" <opensource.kernel@...o.com>
Subject: Re: [PATCH v2] scsi: iscsi: kfree_sensitive() in iscsi_session_free()
On 7/19/23 2:45 AM, 杜敏杰 wrote:
> session might contain private part of the password, so better use
> kfree_sensitive() to free it.
> In iscsi_session_free() use kfree_sensitive() to free session->password,
> session->password_in, session->username, session->username_in.
>
> Signed-off-by: Minjie Du <duminjie@...o.com>
> ---
> drivers/scsi/libiscsi.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/scsi/libiscsi.c b/drivers/scsi/libiscsi.c
> index 0fda8905e..a307da898 100644
> --- a/drivers/scsi/libiscsi.c
> +++ b/drivers/scsi/libiscsi.c
> @@ -3132,10 +3132,10 @@ void iscsi_session_free(struct iscsi_cls_session *cls_session)
> struct module *owner = cls_session->transport->owner;
>
> iscsi_pool_free(&session->cmdpool);
> - kfree(session->password);
> - kfree(session->password_in);
> - kfree(session->username);
> - kfree(session->username_in);
> + kfree_sensitive(session->password);
> + kfree_sensitive(session->password_in);
> + kfree_sensitive(session->username);
> + kfree_sensitive(session->username_in);
> kfree(session->targetname);
> kfree(session->targetalias);
> kfree(session->initiatorname);
Reviewed-by: Mike Christie <michael.christie@...cle.com>
Powered by blists - more mailing lists