[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <87mszms2hy.fsf@toke.dk>
Date: Mon, 24 Jul 2023 00:10:33 +0200
From: Toke Høiland-Jørgensen <toke@...e.dk>
To: Dongliang Mu <dzm91@...t.edu.cn>, Kalle Valo <kvalo@...nel.org>
Cc: Dongliang Mu <dzm91@...t.edu.cn>, linux-wireless@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4] wifi: ath9k: fix printk specifier
Dongliang Mu <dzm91@...t.edu.cn> writes:
> Smatch reports:
>
> ath_pci_probe() warn: argument 4 to %lx specifier is cast from pointer
> ath_ahb_probe() warn: argument 4 to %lx specifier is cast from pointer
>
> Fix it by modifying %lx to %p in the printk format string.
>
> Note that with this change, the pointer address will be printed as a
> hashed value by default. This is appropriate because the kernel
> should not leak kernel pointers to user space in an informational
> message. If someone wants to see the real address for debugging
> purposes, this can be achieved with the no_hash_pointers kernel option.
>
> Signed-off-by: Dongliang Mu <dzm91@...t.edu.cn>
Acked-by: Toke Høiland-Jørgensen <toke@...e.dk>
Powered by blists - more mailing lists