linux-kernel - Re: [PATCH v4] wifi: ath9k: fix printk specifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <169029550891.3210124.11487387565117969944.kvalo@kernel.org>
Date:   Tue, 25 Jul 2023 14:31:50 +0000 (UTC)
From:   Kalle Valo <kvalo@...nel.org>
To:     Dongliang Mu <dzm91@...t.edu.cn>
Cc:     Toke Høiland-Jørgensen <toke@...e.dk>,
        Dongliang Mu <dzm91@...t.edu.cn>,
        linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4] wifi: ath9k: fix printk specifier

Dongliang Mu <dzm91@...t.edu.cn> wrote:

> Smatch reports:
> 
> ath_pci_probe() warn: argument 4 to %lx specifier is cast from pointer
> ath_ahb_probe() warn: argument 4 to %lx specifier is cast from pointer
> 
> Fix it by modifying %lx to %p in the printk format string.
> 
> Note that with this change, the pointer address will be printed as a
> hashed value by default. This is appropriate because the kernel
> should not leak kernel pointers to user space in an informational
> message. If someone wants to see the real address for debugging
> purposes, this can be achieved with the no_hash_pointers kernel option.
> 
> Signed-off-by: Dongliang Mu <dzm91@...t.edu.cn>
> Acked-by: Toke Høiland-Jørgensen <toke@...e.dk>
> Signed-off-by: Kalle Valo <quic_kvalo@...cinc.com>

Patch applied to ath-next branch of ath.git, thanks.

061115fbfb2c wifi: ath9k: fix printk specifier

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20230723040403.296723-1-dzm91@hust.edu.cn/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches