linux-kernel - Re: [PATCH v2 7/8] iio: core: Move initcalls closer to the respective calls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230723102335.6df07e6d@jic23-huawei>
Date:   Sun, 23 Jul 2023 10:23:35 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org,
        Lars-Peter Clausen <lars@...afoo.de>,
        Nuno Sa <nuno.sa@...log.com>
Subject: Re: [PATCH v2 7/8] iio: core: Move initcalls closer to the
 respective calls

On Fri, 21 Jul 2023 20:00:21 +0300
Andy Shevchenko <andriy.shevchenko@...ux.intel.com> wrote:

> Move subsys_initcall() and module_exit() closer to the respective calls.

Why? For this particular set of macros I can see advantages to them being
near the code and to them being in a fairly predictable location (end of
file).

I think the patch description should make the why argument. 

Jonathan


> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> Reviewed-by: Nuno Sa <nuno.sa@...log.com>
> ---
>  drivers/iio/industrialio-core.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/iio/industrialio-core.c b/drivers/iio/industrialio-core.c
> index a9b9804097ab..5c9c68d69fc6 100644
> --- a/drivers/iio/industrialio-core.c
> +++ b/drivers/iio/industrialio-core.c
> @@ -354,6 +354,7 @@ static int __init iio_init(void)
>  error_nothing:
>  	return ret;
>  }
> +subsys_initcall(iio_init);
>  
>  static void __exit iio_exit(void)
>  {
> @@ -362,6 +363,7 @@ static void __exit iio_exit(void)
>  	bus_unregister(&iio_bus_type);
>  	debugfs_remove(iio_debugfs_dentry);
>  }
> +module_exit(iio_exit);
>  
>  #if defined(CONFIG_DEBUG_FS)
>  static ssize_t iio_debugfs_read_reg(struct file *file, char __user *userbuf,
> @@ -2118,9 +2120,6 @@ int iio_device_get_current_mode(struct iio_dev *indio_dev)
>  }
>  EXPORT_SYMBOL_GPL(iio_device_get_current_mode);
>  
> -subsys_initcall(iio_init);
> -module_exit(iio_exit);
> -
>  MODULE_AUTHOR("Jonathan Cameron <jic23@...nel.org>");
>  MODULE_DESCRIPTION("Industrial I/O core");
>  MODULE_LICENSE("GPL");