linux-kernel - Re: [PATCH v2 8/8] iio: core: Improve indentation in a few places

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230723102443.7bcb1abb@jic23-huawei>
Date:   Sun, 23 Jul 2023 10:24:43 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org,
        Lars-Peter Clausen <lars@...afoo.de>,
        Nuno Sa <nuno.sa@...log.com>
Subject: Re: [PATCH v2 8/8] iio: core: Improve indentation in a few places

On Fri, 21 Jul 2023 20:00:22 +0300
Andy Shevchenko <andriy.shevchenko@...ux.intel.com> wrote:

> Improve an indentation in a few places to increase readability.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> Reviewed-by: Nuno Sa <nuno.sa@...log.com>
Applied to the togreg branch of iio.git and pushed out as testing
for 0-day to not notice any change (hopefully ;)

Jonathan

> ---
>  drivers/iio/industrialio-core.c | 23 ++++++++++-------------
>  1 file changed, 10 insertions(+), 13 deletions(-)
> 
> diff --git a/drivers/iio/industrialio-core.c b/drivers/iio/industrialio-core.c
> index 5c9c68d69fc6..e1293fdbc0ef 100644
> --- a/drivers/iio/industrialio-core.c
> +++ b/drivers/iio/industrialio-core.c
> @@ -206,9 +206,9 @@ bool iio_buffer_enabled(struct iio_dev *indio_dev)
>  {
>  	struct iio_dev_opaque *iio_dev_opaque = to_iio_dev_opaque(indio_dev);
>  
> -	return iio_dev_opaque->currentmode
> -		& (INDIO_BUFFER_TRIGGERED | INDIO_BUFFER_HARDWARE |
> -		   INDIO_BUFFER_SOFTWARE);
> +	return iio_dev_opaque->currentmode &
> +	       (INDIO_BUFFER_HARDWARE | INDIO_BUFFER_SOFTWARE |
> +		INDIO_BUFFER_TRIGGERED);
>  }
>  EXPORT_SYMBOL_GPL(iio_buffer_enabled);
>  
> @@ -388,8 +388,8 @@ static ssize_t iio_debugfs_read_reg(struct file *file, char __user *userbuf,
>  	}
>  
>  	iio_dev_opaque->read_buf_len = snprintf(iio_dev_opaque->read_buf,
> -					      sizeof(iio_dev_opaque->read_buf),
> -					      "0x%X\n", val);
> +						sizeof(iio_dev_opaque->read_buf),
> +						"0x%X\n", val);
>  
>  	return simple_read_from_buffer(userbuf, count, ppos,
>  				       iio_dev_opaque->read_buf,
> @@ -492,8 +492,7 @@ static ssize_t iio_read_channel_ext_info(struct device *dev,
>  
>  static ssize_t iio_write_channel_ext_info(struct device *dev,
>  				     struct device_attribute *attr,
> -				     const char *buf,
> -					 size_t len)
> +				     const char *buf, size_t len)
>  {
>  	struct iio_dev *indio_dev = dev_to_iio_dev(dev);
>  	struct iio_dev_attr *this_attr = to_iio_dev_attr(attr);
> @@ -585,9 +584,9 @@ static int iio_setup_mount_idmatrix(const struct device *dev,
>  ssize_t iio_show_mount_matrix(struct iio_dev *indio_dev, uintptr_t priv,
>  			      const struct iio_chan_spec *chan, char *buf)
>  {
> -	const struct iio_mount_matrix *mtx = ((iio_get_mount_matrix_t *)
> -					      priv)(indio_dev, chan);
> +	const struct iio_mount_matrix *mtx;
>  
> +	mtx = ((iio_get_mount_matrix_t *)priv)(indio_dev, chan);
>  	if (IS_ERR(mtx))
>  		return PTR_ERR(mtx);
>  
> @@ -1025,14 +1024,12 @@ int __iio_device_attr_init(struct device_attribute *dev_attr,
>  	if (chan->modified && (shared_by == IIO_SEPARATE)) {
>  		if (chan->extend_name)
>  			full_postfix = kasprintf(GFP_KERNEL, "%s_%s_%s",
> -						 iio_modifier_names[chan
> -								    ->channel2],  
> +						 iio_modifier_names[chan->channel2],
>  						 chan->extend_name,
>  						 postfix);
>  		else
>  			full_postfix = kasprintf(GFP_KERNEL, "%s_%s",
> -						 iio_modifier_names[chan
> -								    ->channel2],  
> +						 iio_modifier_names[chan->channel2],
>  						 postfix);
>  	} else {
>  		if (chan->extend_name == NULL || shared_by != IIO_SEPARATE)