linux-kernel - Re: [PATCH v3 2/2] firmware: stratix10-rsu: query spt addresses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4faac72e-3ab8-6a07-dad0-7be8840da7c4@kernel.org>
Date:   Mon, 24 Jul 2023 09:39:58 -0500
From:   Dinh Nguyen <dinguyen@...nel.org>
To:     "Lee, Kah Jing" <kah.jing.lee@...el.com>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Bacrau, Radu" <radu.bacrau@...el.com>,
        "Ang, Tien Sung" <tien.sung.ang@...el.com>
Subject: Re: [PATCH v3 2/2] firmware: stratix10-rsu: query spt addresses



On 7/20/23 21:34, Lee, Kah Jing wrote:
> Hi Dinh,
> 
> Any feedback on this patch ?
> 

Please fix these checkpatch warnings:

CHECK: Alignment should match open parenthesis
#64: FILE: drivers/firmware/stratix10-rsu.c:275:
+static void rsu_get_spt_callback(struct stratix10_svc_client *client,
+                                    struct stratix10_svc_cb_data *data)

CHECK: Unnecessary parentheses around 'data->status != BIT(SVC_STATUS_OK)'
#70: FILE: drivers/firmware/stratix10-rsu.c:281:
+       if ((data->status != BIT(SVC_STATUS_OK)) || (*mbox_err) ||
+           (*resp_len != RSU_GET_SPT_RESP_LEN))

CHECK: Alignment should match open parenthesis
#116: FILE: drivers/firmware/stratix10-rsu.c:626:
+static ssize_t spt0_address_show(struct device *dev,
+                                 struct device_attribute *attr, char *buf)

CHECK: Alignment should match open parenthesis
#130: FILE: drivers/firmware/stratix10-rsu.c:640:
+static ssize_t spt1_address_show(struct device *dev,
+                                 struct device_attribute *attr, char *buf)

CHECK: Alignment should match open parenthesis
#190: FILE: drivers/firmware/stratix10-rsu.c:787:
+               ret = rsu_send_msg(priv, COMMAND_MBOX_SEND_CMD,
+                               RSU_GET_SPT_CMD, rsu_get_spt_callback);