linux-kernel - [PATCH v2] driver core: Call dma_cleanup() on the test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <0-v2-4deed94e283e+40948-really_probe_dma_cleanup_jgg@nvidia.com>
Date:   Mon, 24 Jul 2023 14:40:46 -0300
From:   Jason Gunthorpe <jgg@...dia.com>
To:     "Rafael J. Wysocki" <rafael@...nel.org>
Cc:     Lu Baolu <baolu.lu@...ux.intel.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Joerg Roedel <jroedel@...e.de>,
        Zenghui Yu <yuzenghui@...wei.com>, linux-kernel@...r.kernel.org
Subject: [PATCH v2] driver core: Call dma_cleanup() on the test_remove path

When test_remove is enabled really_probe() does not properly pair
dma_configure() with dma_remove(), it will end up calling dma_configure()
twice. This corrupts the owner_cnt and renders the group unusable with
VFIO/etc.

Add the missing cleanup before going back to re_probe.

Fixes: 25f3bcfc54bc ("driver core: Add dma_cleanup callback in bus_type")
Reported-by: Zenghui Yu <yuzenghui@...wei.com>
Tested-by: Zenghui Yu <yuzenghui@...wei.com>
Closes: https://lore.kernel.org/all/6472f254-c3c4-8610-4a37-8d9dfdd54ce8@huawei.com/
Signed-off-by: Jason Gunthorpe <jgg@...dia.com>
---
 drivers/base/dd.c | 2 ++
 1 file changed, 2 insertions(+)

v2:
 - Post to correct lists, add Tested-by

diff --git a/drivers/base/dd.c b/drivers/base/dd.c
index 878aa7646b37e4..a528cec24264ab 100644
--- a/drivers/base/dd.c
+++ b/drivers/base/dd.c
@@ -693,6 +693,8 @@ static int really_probe(struct device *dev, struct device_driver *drv)
 
 		device_remove(dev);
 		driver_sysfs_remove(dev);
+		if (dev->bus && dev->bus->dma_cleanup)
+			dev->bus->dma_cleanup(dev);
 		device_unbind_cleanup(dev);
 
 		goto re_probe;

base-commit: 06c2afb862f9da8dc5efa4b6076a0e48c3fbaaa5
-- 
2.41.0