linux-kernel - RE: [PATCH v2] driver core: Call dma_cleanup() on the test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <BN9PR11MB527672A6DEE8471B3B6BEE9F8C01A@BN9PR11MB5276.namprd11.prod.outlook.com>
Date:   Thu, 27 Jul 2023 05:35:25 +0000
From:   "Tian, Kevin" <kevin.tian@...el.com>
To:     Jason Gunthorpe <jgg@...dia.com>,
        "Rafael J. Wysocki" <rafael@...nel.org>
CC:     Lu Baolu <baolu.lu@...ux.intel.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "Rodel, Jorg" <jroedel@...e.de>, Zenghui Yu <yuzenghui@...wei.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v2] driver core: Call dma_cleanup() on the test_remove
 path

> From: Jason Gunthorpe <jgg@...dia.com>
> Sent: Tuesday, July 25, 2023 1:41 AM
> 
> When test_remove is enabled really_probe() does not properly pair
> dma_configure() with dma_remove(), it will end up calling dma_configure()
> twice. This corrupts the owner_cnt and renders the group unusable with
> VFIO/etc.
> 
> Add the missing cleanup before going back to re_probe.
> 
> Fixes: 25f3bcfc54bc ("driver core: Add dma_cleanup callback in bus_type")
> Reported-by: Zenghui Yu <yuzenghui@...wei.com>
> Tested-by: Zenghui Yu <yuzenghui@...wei.com>
> Closes: https://lore.kernel.org/all/6472f254-c3c4-8610-4a37-
> 8d9dfdd54ce8@...wei.com/
> Signed-off-by: Jason Gunthorpe <jgg@...dia.com>

Reviewed-by: Kevin Tian <kevin.tian@...el.com>