linux-kernel - Re: [PATCH] dt-bindings: net: rockchip-dwmac: fix {tx|rx}-delay defaults in schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230725161156.22uscijrot7gbnvj@mercury.elektranox.org>
Date:   Tue, 25 Jul 2023 18:11:56 +0200
From:   Sebastian Reichel <sebastian.reichel@...labora.com>
To:     Eugen Hristev <eugen.hristev@...labora.com>
Cc:     linux-kernel@...r.kernel.org, linux-rockchip@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
        netdev@...r.kernel.org, david.wu@...k-chips.com, heiko@...ech.de,
        krzysztof.kozlowski+dt@...aro.org, kernel@...labora.com
Subject: Re: [PATCH] dt-bindings: net: rockchip-dwmac: fix {tx|rx}-delay
 defaults in schema

Hi,

On Tue, Jul 25, 2023 at 06:52:54PM +0300, Eugen Hristev wrote:
> The defaults are specified in the description instead of being specified
> in the schema.
> Fix it by adding the default value in the `default` field.
> 
> Fixes: b331b8ef86f0 ("dt-bindings: net: convert rockchip-dwmac to json-schema")
> Signed-off-by: Eugen Hristev <eugen.hristev@...labora.com>
> ---

Maybe also fix the allowed range while at it? I.e.

minimum: 0x00
maximum: 0x7F

-- Sebastian

>  Documentation/devicetree/bindings/net/rockchip-dwmac.yaml | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml b/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml
> index bb943c96c196..6d08260ad828 100644
> --- a/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml
> +++ b/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml
> @@ -92,12 +92,14 @@ properties:
>      $ref: /schemas/types.yaml#/definitions/phandle
>  
>    tx_delay:
> -    description: Delay value for TXD timing. Range value is 0~0x7F, 0x30 as default.
> +    description: Delay value for TXD timing. Range value is 0~0x7F.
>      $ref: /schemas/types.yaml#/definitions/uint32
> +    default: 0x30
>  
>    rx_delay:
> -    description: Delay value for RXD timing. Range value is 0~0x7F, 0x10 as default.
> +    description: Delay value for RXD timing. Range value is 0~0x7F.
>      $ref: /schemas/types.yaml#/definitions/uint32
> +    default: 0x10
>  
>    phy-supply:
>      description: PHY regulator
> -- 
> 2.34.1
> 
> 
> -- 
> To unsubscribe, send mail to kernel-unsubscribe@...ts.collabora.co.uk.

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)