linux-kernel - Re: [PATCH] dt-bindings: net: rockchip-dwmac: fix {tx|rx}-delay defaults in schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230725-sulphuric-syndrome-3eaace57ef43@spud>
Date:   Tue, 25 Jul 2023 20:30:51 +0100
From:   Conor Dooley <conor@...nel.org>
To:     Sebastian Reichel <sebastian.reichel@...labora.com>
Cc:     Eugen Hristev <eugen.hristev@...labora.com>,
        linux-kernel@...r.kernel.org, linux-rockchip@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
        netdev@...r.kernel.org, david.wu@...k-chips.com, heiko@...ech.de,
        krzysztof.kozlowski+dt@...aro.org, kernel@...labora.com
Subject: Re: [PATCH] dt-bindings: net: rockchip-dwmac: fix {tx|rx}-delay
 defaults in schema

On Tue, Jul 25, 2023 at 06:11:56PM +0200, Sebastian Reichel wrote:
> Hi,
> 
> On Tue, Jul 25, 2023 at 06:52:54PM +0300, Eugen Hristev wrote:
> > The defaults are specified in the description instead of being specified
> > in the schema.
> > Fix it by adding the default value in the `default` field.
> > 
> > Fixes: b331b8ef86f0 ("dt-bindings: net: convert rockchip-dwmac to json-schema")
> > Signed-off-by: Eugen Hristev <eugen.hristev@...labora.com>
> > ---
> 
> Maybe also fix the allowed range while at it? I.e.
> 
> minimum: 0x00
> maximum: 0x7F

Beat me to it! Please do.

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)