linux-kernel - Re: [PATCH v4] i2c: imx-lpi2c: return -EINVAL when i2c peripheral clk doesn't work

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230725234102.louqs6gvlhfehjur@intel.intel>
Date:   Wed, 26 Jul 2023 01:41:02 +0200
From:   Andi Shyti <andi.shyti@...nel.org>
To:     carlos.song@....com
Cc:     u.kleine-koenig@...gutronix.de, aisheng.dong@....com,
        shawnguo@...nel.org, s.hauer@...gutronix.de, kernel@...gutronix.de,
        festevam@...il.com, xiaoning.wang@....com, haibo.chen@....com,
        linux-imx@....com, linux-i2c@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4] i2c: imx-lpi2c: return -EINVAL when i2c peripheral
 clk doesn't work

Hi Carlos,

> --- a/drivers/i2c/busses/i2c-imx-lpi2c.c
> +++ b/drivers/i2c/busses/i2c-imx-lpi2c.c
> @@ -209,6 +209,9 @@ static int lpi2c_imx_config(struct lpi2c_imx_struct *lpi2c_imx)
>  	lpi2c_imx_set_mode(lpi2c_imx);
>  
>  	clk_rate = clk_get_rate(lpi2c_imx->clks[0].clk);
> +	if (!clk_rate)
> +		return -EINVAL;
> +

this is a very unlikely to happen and generally not really
appreciated.

If you got so far it's basically impossible that clk_rate is '0'.
Uwe asked you in v2 if you actually had such case.

I don't have a strong opinion, thoug... I would drop this patch
unless Dong is OK with it and I can accept it with his ack.

Andi

>  	if (lpi2c_imx->mode == HS || lpi2c_imx->mode == ULTRA_FAST)
>  		filt = 0;
>  	else
> -- 
> 2.34.1
>