[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20230725083117.2745327-1-carlos.song@nxp.com>
Date: Tue, 25 Jul 2023 16:31:17 +0800
From: carlos.song@....com
To: u.kleine-koenig@...gutronix.de, andi.shyti@...nel.org,
aisheng.dong@....com, shawnguo@...nel.org, s.hauer@...gutronix.de,
kernel@...gutronix.de, festevam@...il.com
Cc: carlos.song@....com, xiaoning.wang@....com, haibo.chen@....com,
linux-imx@....com, linux-i2c@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: [PATCH v4] i2c: imx-lpi2c: return -EINVAL when i2c peripheral clk doesn't work
From: Gao Pan <pandy.gao@....com>
When i2c peripheral clk rate is 0 directly return -EINVAL.
Signed-off-by: Gao Pan <pandy.gao@....com>
Signed-off-by: Carlos Song <carlos.song@....com>
---
Changes for V2:
- adjust the subject from "debug message" to "error message"
Changes for V3:
- remove output error log when i2c peripheral clk doesn't work
- adjust commit log and subject
---
drivers/i2c/busses/i2c-imx-lpi2c.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/i2c/busses/i2c-imx-lpi2c.c b/drivers/i2c/busses/i2c-imx-lpi2c.c
index c3287c887c6f..150d923ca7f1 100644
--- a/drivers/i2c/busses/i2c-imx-lpi2c.c
+++ b/drivers/i2c/busses/i2c-imx-lpi2c.c
@@ -209,6 +209,9 @@ static int lpi2c_imx_config(struct lpi2c_imx_struct *lpi2c_imx)
lpi2c_imx_set_mode(lpi2c_imx);
clk_rate = clk_get_rate(lpi2c_imx->clks[0].clk);
+ if (!clk_rate)
+ return -EINVAL;
+
if (lpi2c_imx->mode == HS || lpi2c_imx->mode == ULTRA_FAST)
filt = 0;
else
--
2.34.1
Powered by blists - more mailing lists