[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZL+MaK820fzdfw+5@alpha.franken.de>
Date: Tue, 25 Jul 2023 10:48:40 +0200
From: Thomas Bogendoerfer <tsbogend@...ha.franken.de>
To: Rob Herring <robh@...nel.org>
Cc: Florian Fainelli <florian.fainelli@...adcom.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@...adcom.com>,
John Crispin <john@...ozen.org>, devicetree@...r.kernel.org,
linux-mips@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] MIPS: Explicitly include correct DT includes
On Fri, Jul 14, 2023 at 11:40:27AM -0600, Rob Herring wrote:
> The DT of_device.h and of_platform.h date back to the separate
> of_platform_bus_type before it as merged into the regular platform bus.
> As part of that merge prepping Arm DT support 13 years ago, they
> "temporarily" include each other. They also include platform_device.h
> and of.h. As a result, there's a pretty much random mix of those include
> files used throughout the tree. In order to detangle these headers and
> replace the implicit includes with struct declarations, users need to
> explicitly include the correct includes.
>
> Signed-off-by: Rob Herring <robh@...nel.org>
> ---
> arch/mips/bmips/setup.c | 1 -
> arch/mips/cavium-octeon/flash_setup.c | 3 ++-
> arch/mips/lantiq/irq.c | 2 +-
> arch/mips/lantiq/xway/dcdc.c | 3 ++-
> arch/mips/lantiq/xway/gptu.c | 4 ++--
> arch/mips/lantiq/xway/sysctrl.c | 1 -
> arch/mips/lantiq/xway/vmmc.c | 3 ++-
> arch/mips/pci/pci-lantiq.c | 4 ++--
> arch/mips/pci/pci-rt2880.c | 5 ++---
> arch/mips/pic32/pic32mzda/config.c | 1 -
> arch/mips/ralink/irq.c | 2 +-
> arch/mips/ralink/of.c | 2 +-
> arch/mips/ralink/prom.c | 2 --
> 13 files changed, 15 insertions(+), 18 deletions(-)
applied to mips-next.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
Powered by blists - more mailing lists