linux-kernel - Re: [PATCH 0/3] MIPS: Fix build issues from the introduction of `need-compiler'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZL+LfqvL/tBGnUF3@alpha.franken.de>
Date:   Tue, 25 Jul 2023 10:44:46 +0200
From:   Thomas Bogendoerfer <tsbogend@...ha.franken.de>
To:     "Maciej W. Rozycki" <macro@...am.me.uk>
Cc:     Jan-Benedict Glaw <jbglaw@...-owl.de>,
        Guillaume Tucker <guillaume.tucker@...labora.com>,
        Huacai Chen <chenhuacai@...ngson.cn>,
        linux-mips@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/3] MIPS: Fix build issues from the introduction of
 `need-compiler'

On Tue, Jul 18, 2023 at 03:37:13PM +0100, Maciej W. Rozycki wrote:
> Hi,
> 
>  With the addition of the `need-compiler' variable the `Makefile.compiler' 
> fragment is not included with no-build targets such as `modules_install', 
> which in turn means $(call cc-option,), etc. are no-ops with these targets 
> and any attempt to evaluate these function calls causes all kinds of weird 
> behaviour to happen.
> 
>  The solution is to avoid making these calls in the first place, as they 
> are surely irrelevant where the compiler is not going to be otherwise 
> invoked.  This small patch series fixes two places known-affected in the 
> MIPS Makefile fragment and also included a follow-up revert of an earlier 
> misguided attempt.  See individual change descriptions for details.
> 
>  Verified with `decstation_64_defconfig' and `fuloong2e_defconfig' using 
> `modules_install'.  Please apply.

series applied to mips-next.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]