[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20230725123045.6367-1-aboutphysycs@gmail.com>
Date: Tue, 25 Jul 2023 15:30:45 +0300
From: Andrei Coardos <aboutphysycs@...il.com>
To: linux-kernel@...r.kernel.org, linux-gpio@...r.kernel.org
Cc: andy@...nel.org, brgl@...ev.pl, linus.walleij@...aro.org,
Andrei Coardos <aboutphysycs@...il.com>,
Alexandru Ardelean <alex@...uggie.ro>
Subject: [PATCH v2] gpio: mlxbf2: remove unneeded platform_set_drvdata() call
This function call was found to be unnecessary as there is no equivalent
platform_get_drvdata() call to access the private data of the driver.
Also, the private data is defined in this driver, so there is no risk of
it being accessed outside of this driver file.
Reviewed-by: Alexandru Ardelean <alex@...uggie.ro>
Signed-off-by: Andrei Coardos <aboutphysycs@...il.com>
---
Changelog V1->V2:
* https://lore.kernel.org/linux-gpio/20230720134845.23727-1-aboutphysycs@gmail.com
* fixed subject line: adjusted colons where needed
drivers/gpio/gpio-mlxbf2.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpio/gpio-mlxbf2.c b/drivers/gpio/gpio-mlxbf2.c
index 6abe01bc39c3..cf91b6e74d88 100644
--- a/drivers/gpio/gpio-mlxbf2.c
+++ b/drivers/gpio/gpio-mlxbf2.c
@@ -420,8 +420,6 @@ mlxbf2_gpio_probe(struct platform_device *pdev)
}
}
- platform_set_drvdata(pdev, gs);
-
ret = devm_gpiochip_add_data(dev, &gs->gc, gs);
if (ret) {
dev_err(dev, "Failed adding memory mapped gpiochip\n");
--
2.34.1
Powered by blists - more mailing lists