linux-kernel - Re: [PATCH v2] gpio: mlxbf2: remove unneeded platform_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZL/KZ2Q5G7JHZMhw@smile.fi.intel.com>
Date:   Tue, 25 Jul 2023 16:13:11 +0300
From:   Andy Shevchenko <andy@...nel.org>
To:     Andrei Coardos <aboutphysycs@...il.com>
Cc:     linux-kernel@...r.kernel.org, linux-gpio@...r.kernel.org,
        brgl@...ev.pl, linus.walleij@...aro.org,
        Alexandru Ardelean <alex@...uggie.ro>
Subject: Re: [PATCH v2] gpio: mlxbf2: remove unneeded platform_set_drvdata()
 call

On Tue, Jul 25, 2023 at 03:30:45PM +0300, Andrei Coardos wrote:
> This function call was found to be unnecessary as there is no equivalent
> platform_get_drvdata() call to access the private data of the driver.

This is simply not true.

NAK.

> Also, the private data is defined in this driver, so there is no risk of
> it being accessed outside of this driver file.

-- 
With Best Regards,
Andy Shevchenko