linux-kernel - Re: [PATCH v2] gpio: mlxbf2: remove unneeded platform_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMRc=Mft3dTT+4H=4f4szSCc_NhJkDoG1xs8DkR=urgdhhHeqA@mail.gmail.com>
Date:   Tue, 1 Aug 2023 21:20:40 +0200
From:   Bartosz Golaszewski <brgl@...ev.pl>
To:     Andy Shevchenko <andy@...nel.org>
Cc:     Andrei Coardos <aboutphysycs@...il.com>,
        linux-kernel@...r.kernel.org, linux-gpio@...r.kernel.org,
        linus.walleij@...aro.org, Alexandru Ardelean <alex@...uggie.ro>
Subject: Re: [PATCH v2] gpio: mlxbf2: remove unneeded platform_set_drvdata() call

On Tue, Jul 25, 2023 at 3:13 PM Andy Shevchenko <andy@...nel.org> wrote:
>
> On Tue, Jul 25, 2023 at 03:30:45PM +0300, Andrei Coardos wrote:
> > This function call was found to be unnecessary as there is no equivalent
> > platform_get_drvdata() call to access the private data of the driver.
>
> This is simply not true.
>
> NAK.
>

Just so you know if that's not obvious from reading the code:
platform_get_drvdata() is just a wrapper around dev_get_drvdata()
which is called plenty in PM callbacks of this driver.

Bart

> > Also, the private data is defined in this driver, so there is no risk of
> > it being accessed outside of this driver file.
>
> --
> With Best Regards,
> Andy Shevchenko
>
>