linux-kernel - Re: [PATCH V3 7/9] x86/hyperv: Initialize cpu and memory for SEV-SNP enlightened guest

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9c690209-4a1c-842f-064b-66ae5c8d870f@gmail.com>
Date:   Wed, 26 Jul 2023 22:15:27 +0800
From:   Tianyu Lan <ltykernel@...il.com>
To:     Jinank Jain <jinankjain@...ux.microsoft.com>, kys@...rosoft.com,
        haiyangz@...rosoft.com, wei.liu@...nel.org, decui@...rosoft.com,
        tglx@...utronix.de, mingo@...hat.com, bp@...en8.de,
        dave.hansen@...ux.intel.com, x86@...nel.org, hpa@...or.com,
        daniel.lezcano@...aro.org, arnd@...db.de,
        michael.h.kelley@...rosoft.com
Cc:     Tianyu Lan <tiala@...rosoft.com>, linux-arch@...r.kernel.org,
        linux-hyperv@...r.kernel.org, linux-kernel@...r.kernel.org,
        vkuznets@...hat.com, Michael Kelley <mikelley@...rosoft.com>
Subject: Re: [PATCH V3 7/9] x86/hyperv: Initialize cpu and memory for SEV-SNP
 enlightened guest

On 7/26/2023 12:26 PM, Jinank Jain wrote:
>> +    /*
>> +     * Hyper-V SEV-SNP enlightened guest doesn't support ioapic
>> +     * and legacy APIC page read/write. Switch to hv apic here.
>> +     */
>> +    disable_ioapic_support();
> 
> Where are we switching hv_apic? May I am missing something here?
>

Nice catch! It's fossil comment when there is no x2apic support.
Will fix it in the next version.